Collection of fixes for bugs found on livestream #10392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
each commit is a different fix!
abbf61b fixes microsoft/pxt-arcade#6685 which was an issue with the bitmap equality function not handling the case where the floating layer's bitmap was set to undefined.
4061281 fixes microsoft/pxt-arcade#6686 by making sure that the image canvas properly takes focus when interacting with it.
dc6b429 fixes a longstanding issue where the first pixel was skipped when starting a drag
dd36705 removes a monkey patch for the variable field that no longer works with latest blockly; this was causing sprite kinds to show up in the regular variable blocks. now we filter the variable dropdown properly by passing an array with an empty string in the JSON config of all our blocks that use this field.